* fix(ux): increase readability of install step
The official github self-hosted action container does not include curl in the OS
but because the `curl` command in the GH Action's install step redirects stderr
to /dev/null, it was hard to determine that.
As part of my Dagger interview, @gerhard and I investigated and found that issue.
We changed the `curl` flags from `-sL` to `-fsS` to be more verbose with the
error reporting and remove following redirects, as the move to Cloudfront
obviated the need for that flag.
We also removed the subshell in the install step at the end because it was not
needed and introduced extra complexity.
I could also see checking for the presence of curl at the beginning of the
script and failing quickly with a message, but that was not discussed in the
interview. Given that this happens very quickly and solves for other HTTP errors
it doesn't seem particularly necessary but I could see the potential for it, if
the desire for it was there.
Signed-off-by: Josh Ghiloni <ghiloni@gmail.com>
* Use pipefail when we pipe commands
Use clearer syntax with pipes (functional style similar to Elixir).
Make the shell & if / env obvious in the commands by declaring them
first in the step.
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
---------
Signed-off-by: Josh Ghiloni <ghiloni@gmail.com>
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Co-authored-by: Gerhard Lazu <gerhard@dagger.io>
Since we published https://github.com/dagger/dagger/releases/tag/v0.3.6
(Nov. 30, 2022), this action started downloading that version (i.e.
`latest`), which resulted in breakage, as described in the issue that
this fixes.
As soon as all tests pass and this gets the OK + merge, we should:
1. Cut a new release for this action (I am thinking v3.2.0)
2. Update the v3 tag to point to this new version
That should fix this for all existing GitHub Actions users without any
intervention on their part.
Fixes https://github.com/dagger/dagger-for-github/issues/80
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
