mirrored-actions/dagger-for-github
1
0
Fork 0
mirror of https://github.com/dagger/dagger-for-github.git synced 2026-01-01 21:19:44 +11:00
Code Issues Projects Releases Packages Wiki Activity

remove unnecessary engine-stop (#188)

Browse source 
* remove unnecessary engine-stop

Signed-off-by: kpenfound <kyle@dagger.io>

* add deprecationMessage

Signed-off-by: kpenfound <kyle@dagger.io>

---------

Signed-off-by: kpenfound <kyle@dagger.io>
This commit is contained in:
Kyle Penfound 2025-09-16 14:49:30 -04:00 • committed by GitHub
parent 4e0ad19142
commit c8eadbd788
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

5
README.md
View file

@ -11,7 +11,7 @@
module: github.com/shykes/daggerverse/hello module: github.com/shykes/daggerverse/hello
call: hello --greeting Hola --name Jeremy call: hello --greeting Hola --name Jeremy
cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }} cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }}
version: "latest" # semver x.y.z version: "latest" # semver vX.Y.Z
``` ```
### `dagger shell` ### `dagger shell`
@ -34,7 +34,7 @@
verb: run verb: run
args: node build.js args: node build.js
cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }} cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }}
version: "latest" # semver x.y.z version: "latest" # semver vX.Y.Z
``` ```
### Staying in sync with the `latest` version ### Staying in sync with the `latest` version
@ -55,4 +55,3 @@ By setting the version to `latest`, this action will install the latest version
| `args` | Arguments to pass to CLI | false | '' | | `args` | Arguments to pass to CLI | false | '' |
| `call` | Arguments to pass to CLI (Alias for args with verb:call) | false | '' | | `call` | Arguments to pass to CLI (Alias for args with verb:call) | false | '' |
| `shell` | Arguments to pass to CLI (Alias for args with verb:shell) | false | '' | | `shell` | Arguments to pass to CLI (Alias for args with verb:shell) | false | '' |
| `engine-stop` | Whether to stop the Dagger Engine after this run | false | 'true' |

12
action.yml
View file

@ -33,9 +33,9 @@ inputs:
required: false required: false
default: "" default: ""
engine-stop: engine-stop:
description: "Whether to stop the Dagger Engine after this run" description: "Deprecated"
deprecationMessage: "engine-stop is now a no-op and will be removed in a future release"
required: false required: false
default: "true"
call: call:
description: "Function and arguments for dagger call" description: "Function and arguments for dagger call"
required: false required: false
@ -128,11 +128,3 @@ runs:
if [[ -n "$trace_url" ]]; then if [[ -n "$trace_url" ]]; then
echo "traceURL=$trace_url" >> "$GITHUB_OUTPUT" echo "traceURL=$trace_url" >> "$GITHUB_OUTPUT"
fi fi
- if: (inputs.call != '' || inputs.args != '') && inputs.engine-stop == 'true'
shell: bash
run: |
mapfile -t containers < <(docker ps --filter name="dagger-engine-*" -q)
if [[ "${#containers[@]}" -gt 0 ]]; then
docker stop -t 300 "${containers[@]}";
fi