mirrored-actions/add-pr-comment
1
0
Fork 0
mirror of https://github.com/mshick/add-pr-comment.git synced 2025-12-31 14:20:32 +11:00
Code Issues Projects Releases Packages Wiki Activity

feat: do not test user.login by default (#15)

Browse source 
* feat: do not test user.login by default

* ci: define user login in integration test

* ci: define dogfood test separately

* build: new dist build
This commit is contained in:
Michael Shick 2020-05-28 11:43:27 -04:00 • committed by GitHub
parent 150a3ccfe9
commit f533dc4046
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 91 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

48
__tests__/add-pr-comment.test.ts
View file

@ -8,6 +8,7 @@ import run from '../add-pr-comment'
const repoFullName = 'foo/bar'
const repoToken = '12345'
const userLogin = 'github-actions[bot]'
const commitSha = 'abc123'
const issueNumber = 1
const simpleMessage = 'hello world'
@ -17,6 +18,7 @@ const multilineMessageWindows = fs.readFileSync(path.resolve(__dirname, './messa
const inputs = {
message: '',
'repo-token': '',
'repo-token-user-login': '',
'allow-repeats': 'false',
}
@ -84,9 +86,10 @@ describe('add-pr-comment action', () => {
await expect(run()).resolves.not.toThrow()
})
it('safely exits when no issue can be found', async () => {
it('safely exits when no issue can be found [using GITHUB_TOKEN in env]', async () => {
process.env['GITHUB_TOKEN'] = repoToken
inputs.message = simpleMessage
inputs['repo-token'] = repoToken
inputs['allow-repeats'] = 'true'
github.context.payload = {
@ -111,9 +114,10 @@ describe('add-pr-comment action', () => {
await run()
})
it('identifies repeat messages and does not create a comment', async () => {
it('identifies repeat messages and does not create a comment [user login provided]', async () => {
inputs.message = simpleMessage
inputs['repo-token'] = repoToken
inputs['repo-token-user-login'] = userLogin
inputs['allow-repeats'] = 'false'
const originalSetOutput = core.setOutput
@ -126,21 +130,21 @@ describe('add-pr-comment action', () => {
return originalSetOutput(key, value)
})
nock('https://api.github.com')
.get(`/repos/${repoFullName}/issues/1/comments`)
.reply(200, [
{
body: simpleMessage,
user: {
login: 'github-actions[bot]',
},
const replyBody = [
{
body: simpleMessage,
user: {
login: userLogin,
},
])
},
]
nock('https://api.github.com').get(`/repos/${repoFullName}/issues/1/comments`).reply(200, replyBody)
await run()
})
it('matches multiline messages with windows line feeds against api responses with unix linefeeds', async () => {
it('matches multiline messages with windows line feeds against api responses with unix linefeeds [no user login provided]', async () => {
inputs.message = multilineMessageWindows
inputs['repo-token'] = repoToken
inputs['allow-repeats'] = 'false'
@ -155,16 +159,16 @@ describe('add-pr-comment action', () => {
return originalSetOutput(key, value)
})
nock('https://api.github.com')
.get(`/repos/${repoFullName}/issues/1/comments`)
.reply(200, [
{
body: multilineMessage,
user: {
login: 'github-actions[bot]',
},
const replyBody = [
{
body: multilineMessage,
user: {
login: userLogin,
},
])
},
]
nock('https://api.github.com').get(`/repos/${repoFullName}/issues/1/comments`).reply(200, replyBody)
await run()
})